Commit 405087dd50d55c498899bf4b4bb8123ce20f91ad

Authored by Adhidarma Hadiwinoto
1 parent b794b32af9
Exists in master

Fix null retry by using OR 0

Showing 1 changed file with 14 additions and 5 deletions Side-by-side Diff

... ... @@ -107,7 +107,7 @@ function init(cb) {
107 107 }
108 108  
109 109 async function sleepAndResend(partner, msg, params, retry) {
110   - if ((retry || 0) > maxSendRetry) {
  110 + if (retry > maxSendRetry) {
111 111 logger.verbose('Retry exceeded', {
112 112 params,
113 113 retry: retry || 0,
... ... @@ -120,9 +120,18 @@ async function sleepAndResend(partner, msg, params, retry) {
120 120 }
121 121  
122 122 function send(partner, msg, params, retry) {
123   - logger.verbose('Got response from CORE', {
124   - partner: partner, msg: msg, params: params, retry: retry || 0,
125   - });
  123 + if (retry) {
  124 + logger.verbose('F39C9082: Resending', {
  125 + partner,
  126 + msg,
  127 + params,
  128 + retry,
  129 + })
  130 + } else {
  131 + logger.verbose('Got response from CORE', {
  132 + partner: partner, msg: msg, params: params, retry: retry || 0,
  133 + });
  134 + }
126 135  
127 136 if (!params || !params.reverse_url) {
128 137 logger.verbose('Undefined reverse_url, not forwarding message to partner');
... ... @@ -148,7 +157,7 @@ function send(partner, msg, params, retry) {
148 157 request(reqOptions, function(err, res, body) {
149 158 if (err) {
150 159 logger.warn('Error sending reverse report to partner', {request: reqOptions, err: err});
151   - sleepAndResend(partner, msg, params, retry);
  160 + sleepAndResend(partner, msg, params, retry || 0);
152 161 return;
153 162 }
154 163