fix duplicate messages handling

Adhidarma Hadiwinoto
1 parent 1c11675f04
Showing 1 changed file with 9 additions and 5 deletions Side-by-side Diff
index.js
@@ -9,7 +9,7 @@ var strftime = require(&#39;strftime&#39;);
  
 var pollingTimer;
  
-var lastDataOnPM;
+var loggedPM = [];
  
 var logger = require('winston');
 logger.remove(logger.transports.Console);
@@ -87,10 +87,14 @@ function onYmPM(data) {
       console.log(data);
     }
  
-    if (lastDataOnPM != null) {
-        if ((lastDataOnPM.sender == data.sender) && (lastDataOnPM.message == data.message)) {
-            return;
-        }
+    // check duplicate message
+    if (loggedPM.indexOf(data.message_id) >= 0) {
+        return;
+    }
+
+    loggedPM.unshift(data.message_id);
+    if (loggedPM.length > 30) {
+        loggedPM = loggedPM.slice(0, 10);
     }
  
     lastDataOnPM = data;
...	...	@@ -9,7 +9,7 @@ var strftime = require('strftime');
9	9
10	10	var pollingTimer;
11	11
12		-var lastDataOnPM;
	12	+var loggedPM = [];
13	13
14	14	var logger = require('winston');
15	15	logger.remove(logger.transports.Console);
...	...	@@ -87,10 +87,14 @@ function onYmPM(data) {
87	87	console.log(data);
88	88	}
89	89
90		- if (lastDataOnPM != null) {
91		- if ((lastDataOnPM.sender == data.sender) && (lastDataOnPM.message == data.message)) {
92		- return;
93		- }
	90	+ // check duplicate message
	91	+ if (loggedPM.indexOf(data.message_id) >= 0) {
	92	+ return;
	93	+ }
	94	+
	95	+ loggedPM.unshift(data.message_id);
	96	+ if (loggedPM.length > 30) {
	97	+ loggedPM = loggedPM.slice(0, 10);
94	98	}
95	99
96	100	lastDataOnPM = data;