From ee5a6e87a179dc469e64e38b166b829f64c07a4a Mon Sep 17 00:00:00 2001 From: Adhidarma Hadiwinoto <gua@adhisimon.org> Date: Wed, 22 Jul 2015 18:27:44 +0700 Subject: [PATCH] simplified try catch --- partner-datacell.js | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/partner-datacell.js b/partner-datacell.js index 5db3f64..53f0e05 100644 --- a/partner-datacell.js +++ b/partner-datacell.js @@ -115,9 +115,9 @@ function topupResponseHandler(body, request_id) { var message = ''; try { - if (result.datacell.message.length > 0) { + if (result.datacell.message && result.datacell.message.length > 0) { message = result.datacell.message[0].trim(); - } else if (result.datacell.msg.length > 0) { + } else if (result.datacell.msg && result.datacell.msg.length > 0) { message = result.datacell.msg[0].trim(); } } @@ -125,16 +125,11 @@ function topupResponseHandler(body, request_id) { message = 'exception saat parsing message'; } - - try { - if (result.datacell.resultcode[0] == '999') { - response_code = '40'; - } - } - catch(err) { - response_code = '68'; + if (result.datacell.resultcode && result.datacell.resultcode[0] == '999') { + response_code = '40'; } + if (message.indexOf('Nomor tujuan salah') >= 0) { response_code = '14'; } else if (message.indexOf('*GAGAL, transaksi yang sama sudah ada dalam 10 menit') >= 0) { -- 1.9.0