diff --git a/xmlrpc-server.js b/xmlrpc-server.js index daf1326..5cde360 100644 --- a/xmlrpc-server.js +++ b/xmlrpc-server.js @@ -298,7 +298,7 @@ function sendReply(response) { function sendTopUpReport(reverseUrls, params, urlIdx, retry) { if (retry === null || retry === undefined) { - retry = 3; + retry = 1; } if (urlIdx === null || urlIdx === undefined) { @@ -346,21 +346,14 @@ function sendTopUpReport(reverseUrls, params, urlIdx, retry) { client.methodCall(methodName, [ params ], function (topUpReportError, value) { - try { - - if (topUpReportError) { - logger.warn('Error sending topUpReport retrying another url (if available)', {error: topUpReportError}); - sendTopUpReport(reverseUrls, params, ++urlIdx, retry); - return; - } - - logger.verbose("topUpReport ACK", {value: value}); - - } - catch(topUpReportException) { - logger.warn("Exception on sending topUpReport", {e: topUpReportException}); + if (topUpReportError) { + logger.warn('Error sending topUpReport retrying another url (if available)', {error: topUpReportError}); + sendTopUpReport(reverseUrls, params, ++urlIdx, retry); + return; } + logger.verbose("topUpReport ACK", {value: value}); + }); }