From 03cc6fa02bde08504c85513f6ba739fed73bb81a Mon Sep 17 00:00:00 2001
From: Adhidarma Hadiwinoto <gua@adhisimon.org>
Date: Thu, 16 Jun 2016 15:48:29 +0700
Subject: [PATCH] angin segar

---
 xmlrpc-server.js | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/xmlrpc-server.js b/xmlrpc-server.js
index 9576b19..ff08b2b 100644
--- a/xmlrpc-server.js
+++ b/xmlrpc-server.js
@@ -343,20 +343,17 @@ function sendTopUpReport(reverseUrls, params, urlIdx, retry) {
 
     var methodName = 'topUpReport';
     logger.info('Requesting topUpReport', {params: params});
-    client.methodCall(methodName, [ params ], function (error, value) {
+    client.methodCall(methodName, [ params ], function (topupReportError, value) {
 
         try {
 
-            if (error) {
-                if ((error.constructor !== Object) || (Object.keys(error).length === 0)) {
-                    logger.warn('Error sending topUpReport retrying another url (if available)', {error: error, value: value});
-                    sendTopUpReport(reverseUrls, params, ++urlIdx, retry);
-                    return;
-                }
+            if (topupReportError.constructor === Object && Object.keys(topupReportError).length >= 0) {
+                logger.warn('Error sending topUpReport retrying another url (if available)', {error: topupReportError, value: value});
+                sendTopUpReport(reverseUrls, params, ++urlIdx, retry);
+                return;
             }
 
             logger.verbose("topUpReport ACK", {error: error, value: value});
-
         }
         catch(topUpReportException) {
             logger.warn("Exception on sending topUpReport", {e: topUpReportException});
-- 
1.9.0