From ab05a347df0072ae6ece59f0f829a5614737f208 Mon Sep 17 00:00:00 2001
From: Adhidarma Hadiwinoto <adhisimon@gmail.com>
Date: Mon, 9 Aug 2021 14:59:53 +0700
Subject: [PATCH] Fix pemanggilan getMaxValuesForIndicator kosong
---
lib/redis-util.js | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/redis-util.js b/lib/redis-util.js
index 80d709c..15a7ea1 100644
--- a/lib/redis-util.js
+++ b/lib/redis-util.js
@@ -270,11 +270,17 @@ const setMaxValueForIndicator = (product, val, xid) => new Promise((resolve) =>
exports.setMaxValueForIndicator = setMaxValueForIndicator;
const getMaxValuesForIndicator = (products, xid) => new Promise((resolve, reject) => {
- const keywords = products.map((item) => `${composeKeyword(item)}_MAX_VALUE`);
+ const keywords = (products || []).map((item) => `${composeKeyword(item)}_MAX_VALUE`);
+
+ if (!keywords || !keywords.length) {
+ resolve([]);
+ return;
+ }
+
redisClient.mget(...keywords, (err, reply) => {
if (err) {
logger.warn(`63BE7706 ${MODULE_NAME}: Error on getting max values on redis`, {
- xid, eCode: err.code, eMessage: err.message,
+ xid, eCode: err.code, products, keywords, eMessage: err.message,
});
reject(err);
return;
--
1.9.0