From 56ec0ab1f742a3313a7f611a1a08101c534cce6d Mon Sep 17 00:00:00 2001
From: Adhidarma Hadiwinoto <adhisimon@gmail.com>
Date: Mon, 31 May 2021 13:43:47 +0700
Subject: [PATCH] Tune on callback-sender

---
 lib/core-callback/index.js  | 8 +++++---
 lib/core-callback/sender.js | 8 ++++----
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/lib/core-callback/index.js b/lib/core-callback/index.js
index 4f49b6c..41604e0 100644
--- a/lib/core-callback/index.js
+++ b/lib/core-callback/index.js
@@ -1,3 +1,5 @@
+const MODULE_NAME = 'CORE-CALLBACK';
+
 const DEFAULT_LISTENER_FROM_CORE = 25613;
 
 const express = require('express');
@@ -12,7 +14,7 @@ app.use(express.json({ extended: true }));
 app.use(express.urlencoded({ extended: true }));
 
 app.use((req, res, next) => {
-    res.locals.httpgetx_subsystem = 'CORE-CALLBACK';
+    res.locals.httpgetx_subsystem = MODULE_NAME;
     next();
 });
 
@@ -27,8 +29,8 @@ const port = (config.listener && config.listener.core && config.listener.core.po
     || DEFAULT_LISTENER_FROM_CORE;
 
 app.listen(port, () => {
-    logger.info(`Listen from CORE callback on port ${port}`);
+    logger.info(`${MODULE_NAME} 0375DC4E: Listen from CORE callback on port ${port}`);
 }).on('error', (e) => {
-    logger.error(`Can not listen CORE callback on port ${port}. ${e.toString()}`);
+    logger.error(`${MODULE_NAME} A90E42D5: Can not listen CORE callback on port ${port}. ${e.toString()}`);
     process.exit(1);
 });
diff --git a/lib/core-callback/sender.js b/lib/core-callback/sender.js
index c552832..95c408e 100644
--- a/lib/core-callback/sender.js
+++ b/lib/core-callback/sender.js
@@ -23,13 +23,13 @@ const sender = async (data, xid, retry) => {
         destination: data.destination,
         rc: data.rc,
         sn: data.sn,
+        amount: Number(data.amount) || undefined,
+        ending_balance: Number(data.ending_balance) || undefined,
         message: data.message,
-        amount: data.amount,
-        ending_balance: data.ending_balance,
     };
 
-    if (data.command === 'INQUIRY' && data.amount_to_charge) {
-        params.amount_to_charge = data.amount_to_charge;
+    if (data.command === 'INQUIRY' && Number(data.amount_to_charge)) {
+        params.amount_to_charge = Number(data.amount_to_charge);
     }
 
     const fullUrl = urlConcatQs(data.reverse_url, params);
-- 
1.9.0